Skip to content

Fix Meditor loading of recursive standard extensions - #3023

Open
leej3 wants to merge 1 commit into
dandi:masterfrom
leej3:fix/recursive-metadata-schema
Open

leej3 wants to merge 1 commit into
dandi:masterfrom
leej3:fix/recursive-metadata-schema

Conversation

@leej3

@leej3 leej3 commented Nov 17, 2026 •

Copy link
Copy Markdown

Dandiset schema 0.8.1 allows StandardsType.extensions to contain nested StandardsType objects. Dereferencing the schema creates a JavaScript cycle, which causes fixSchema() to throw during JSON.stringify and prevents the editor from loading.

Keep recursive $refs intact so the frontend can serialize the schema and Meditor can validate nested extensions. The Playwright regression verifies that Meditor accepts two levels of extensions and flags a missing schemaKey on the innermost extension.

Testing

  • Reproduced the startup crash with schema 0.8.1 generated by the Python publisher from dandi/dandi-schema revision 0eb4d69c50cbd077834144dec0e2a2dd9ddb31b1.
  • Added and edited a contributor in Meditor against local Django and PostgreSQL. Verified the change after reload and ran the backend validation task synchronously. The draft reached Valid with no errors.
  • Verified the contributor workflow with the production 0.7.0 schema using local API fixtures.
  • Ran the full Playwright suite against the local 0.8.1 backend. All 54 tests passed on the final run.

Keep recursive references as $refs during schema loading so Meditor can
open schemas with recursive StandardsType extensions.

Exercise two levels of extensions in Playwright and verify that Meditor
rejects a missing schemaKey on the innermost extension.

Co-Authored-By: Codex Desktop 26.1111.21308 (runtime codex-cli 0.169.0-alpha.11.1) / gpt-6.2-sol <codex@openai.com>
Codex-Reasoning-Effort: high
@leej3
leej3 marked this pull request as ready for review November 17, 2026 21:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant