Repository navigation
Conversation
Keep recursive references as $refs during schema loading so Meditor can open schemas with recursive StandardsType extensions. Exercise two levels of extensions in Playwright and verify that Meditor rejects a missing schemaKey on the innermost extension. Co-Authored-By: Codex Desktop 26.1111.21308 (runtime codex-cli 0.169.0-alpha.11.1) / gpt-6.2-sol <codex@openai.com> Codex-Reasoning-Effort: high
leej3
marked this pull request as ready for review
November 17, 2026 21:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dandiset schema 0.8.1 allows
StandardsType.extensionsto contain nestedStandardsTypeobjects. Dereferencing the schema creates a JavaScript cycle, which causesfixSchema()to throw duringJSON.stringifyand prevents the editor from loading.Keep recursive
$refs intact so the frontend can serialize the schema and Meditor can validate nested extensions. The Playwright regression verifies that Meditor accepts two levels of extensions and flags a missingschemaKeyon the innermost extension.Testing
dandi/dandi-schemarevision0eb4d69c50cbd077834144dec0e2a2dd9ddb31b1.Validwith no errors.