Skip to content

Fix flaky IAP flow test: spurious async and mock delays #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix flaky IAP flow test: spurious async and mock delays #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
454b3dd
Initial plan
Copilot May 4, 2026
a619f3c
Fix flaky IAP flow test: remove spurious async and mock delays
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iap_refresh_management.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async function update_iap_history_with_apple_if_needed_and_return_updated_user(a
}
}

async function should_iap_transaction_history_be_refreshed(account) {
function should_iap_transaction_history_be_refreshed(account) {
const account_active = (account.expiry && current_time() < account.expiry) ? true : false;
const last_transaction = account.transactions[account.transactions.length - 1];
if (account_active || last_transaction == undefined || last_transaction.type != "iap") {
Expand Down
30 changes: 10 additions & 20 deletions test/controllers/mock_iap_controller.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.