Repository navigation
feat: compose inherited arrays explicitly - #103
Merged
Merged
Conversation
dakusui
force-pushed
the
codex/super-pair-91
branch
from
September 20, 2026 17:10
e50609d to
a3e9af5
Compare
dakusui
added this pull request to stack #106
September 20, 2026 17:16
dakusui
commented
Sep 20, 2026
dakusui
left a comment
dakusui
left a comment
Owner
Author
There was a problem hiding this comment.
Review feedback: one diagnostic-path issue found. The implementation and autotest suites otherwise passed locally.
| case i >= len(queue): | ||
| out = append(out, inherited[i]) | ||
| default: | ||
| paired, err := pairValues(inherited[i], queue[i], policy, appendPathSegment(path, i)) |
Owner
Author
There was a problem hiding this comment.
The recursive merge path uses the pairing offset i, although paired elements are emitted after the literal prefix. For example, a nested composition failure under ["p", "$super*", {...}] reports .m[0] even though the paired result slot is .m[1]. Please use len(prefix)+i for the structural path, or keep the pair offset separate from the output path.
Owner
Author
There was a problem hiding this comment.
Also, please ensure the error message is correct when the mentioned error happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #91.
$super*index-wise pairing for inherited arraysVerification
make testtools/bin/autotest(186 passed)Documentation, changelog, and OpenSpec completion are in the stacked follow-up PR.