feat: add searchSourcePosts query for squad text search#3996
Merged
Conversation
Adds a Mimir-powered searchSourcePosts GraphQL query that searches posts within a single source (squad). Permission is gated via ensureSourcePermissions before any Mimir call so private squads stay private. The Mimir request scopes results with a source_id filter and, since sending any filter suppresses Mimir's own safety defaults, explicitly adds deleted/visible/banned filters instead of the private=false filter used by searchPosts (members must be able to find private squad posts).
|
🍹 The Update (preview) for dailydotdev/api/prod (at 739695f) was successful. Resource Changes Name Type Operation
~ vpc-native-channel-highlights-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-worker-job-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-user-profile-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-materialized-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-lifecycle-state-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-squad-posts-analytics-refresh-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-8e5b54a6 kubernetes:batch/v1:Job create
~ vpc-native-clean-channel-highlights-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-subscription-anniversary-achievements-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-achievements-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-expired-better-auth-sessions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-analytics-history-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-db-migration-f40ae263 kubernetes:batch/v1:Job delete
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-achievement-rarity-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-channel-digests-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-clickhouse-migration-8e5b54a6 kubernetes:batch/v1:Job create
~ vpc-native-materialize-yearly-best-post-archives-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-clickhouse-migration-f40ae263 kubernetes:batch/v1:Job delete
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
... and 15 other changes |
Contributor
Author
|
Related PRs (deploy in this order):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New GraphQL query for text-searching posts within a single source (squad), powered by the existing Mimir integration:
How
ensureSourcePermissions(ctx, source)runs before any Mimir call — private squads throwFORBIDDENfor anonymous users and non-members, same gate assourceFeed.StringListFilteronsource_id, plus explicitBoolFilters fordeleted = false,visible = true,banned = false. These must be explicit because Mimir only injects its safety defaults when a request carries no filters.private = falsefilter (unlikesearchPosts): the permission check already gates access, and squad members must be able to find their private squad's posts.mimirSearchResolverwithallowPrivatePosts: true,removeHiddenPosts: true,removeBannedPosts: false,removeNonPublicThresholdSquads: false— mirroringsourceFeed's scoped-source rationale. Results preserve Mimir's ranked order viafixedIdsFeedBuilder.source/queryinsrc/common/schema/search.ts.Tests
6 new tests in
__tests__/search.ts(Mimir mocked via proto-typedSearchResponseinstances):SearchRequestcontains thesource_idfilter, omitsprivate=false, includes the three safety filtersfirst/afterFull search suite: 42/42 passing. Lint and build clean.
Deploy order
Merge/deploy after the mimir index PR and before the apps PR. Related PRs linked in a comment below.
🤖 Generated with Claude Code