Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions __tests__/highlights.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,44 @@ describe('query postHighlightsFeed', () => {
]);
});

it('should exclude highlights whose post is deleted or not visible', async () => {
await createTestPosts();
await con.getRepository(ArticlePost).update('h2', { deleted: true });
await con.getRepository(ArticlePost).update('h3', { visible: false });
await saveCanonicalHighlights([
{
postId: 'h1',
channel: 'vibes',
highlightedAt: new Date('2026-03-19T10:40:00.000Z'),
headline: 'Visible headline',
significance: HighlightSignificance.Breaking,
},
{
postId: 'h2',
channel: 'vibes',
highlightedAt: new Date('2026-03-19T10:35:00.000Z'),
headline: 'Deleted post headline',
significance: HighlightSignificance.Notable,
},
{
postId: 'h3',
channel: 'agentic',
highlightedAt: new Date('2026-03-19T10:30:00.000Z'),
headline: 'Invisible post headline',
significance: HighlightSignificance.Routine,
},
]);

const res = await client.query(POST_HIGHLIGHTS_FEED_QUERY, {
variables: { first: 10 },
});

expect(res.errors).toBeFalsy();
expect(
res.data.postHighlightsFeed.edges.map(({ node }) => node.post.id),
).toEqual(['h1']);
});

it('should filter by channel', async () => {
await createTestPosts();
await saveCanonicalHighlights([
Expand Down
20 changes: 19 additions & 1 deletion src/schema/highlights.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,20 @@ type HighlightsFilters = {
significances?: HighlightSignificance[];
};

const applyVisiblePostFilter = <T extends HighlightsCanonical>(
builder: SelectQueryBuilder<T>,
alias: string,
): SelectQueryBuilder<T> =>
builder.andWhere(
`EXISTS (
SELECT 1
FROM "post" p
WHERE p."id" = "${alias}"."postId"
AND p."deleted" = false
AND p."visible" = true
)`,
);

const applyHighlightsFilters = <T extends HighlightsCanonical>(
builder: SelectQueryBuilder<T>,
alias: string,
Expand All @@ -188,7 +202,7 @@ const applyHighlightsFilters = <T extends HighlightsCanonical>(
builder.andWhere(`:highlightChannel = ANY("${alias}"."channels")`);
}

return builder;
return applyVisiblePostFilter(builder, alias);
};

const resolveCanonicalHighlightsFeed = (
Expand Down Expand Up @@ -276,6 +290,10 @@ export const resolvers: IResolvers<unknown, BaseContext> = {
})
.orderBy(`"${builder.alias}"."highlightedAt"`, 'DESC')
.addOrderBy(`"${builder.alias}"."id"`, 'DESC');
applyVisiblePostFilter(
builder.queryBuilder as SelectQueryBuilder<HighlightsCanonical>,
builder.alias,
);
return builder;
},
true,
Expand Down
Loading