Repository navigation
feat: add repo-server-address argument - #492
Merged
Merged
Conversation
dag-andersen
requested changes
Sep 16, 2026
dag-andersen
left a comment
dag-andersen
left a comment
Owner
There was a problem hiding this comment.
Thank you for the PR 🚀
Please also update the documentation with this new option
Comment on lines
+26
to
+32
| func TestRepoServerAdressFlag(t *testing.T) { | ||
| if os.Getenv("RUN_IN_CLUSTER_TEST") != "true" { | ||
| t.Skip("Skipping in-cluster integration test. Set RUN_IN_CLUSTER_TEST=true to run.") | ||
| } | ||
|
|
||
| } | ||
|
|
Owner
There was a problem hiding this comment.
I don't think this test brings much value.
Please delete it or implement it properly.
Contributor
Author
There was a problem hiding this comment.
oops, forgot to get rid of that. updated options in docs.
might be an idea to use some form of doc generation (i.e. with cobra https://github.com/spf13/cobra/blob/main/site/content/docgen/md.md)
dag-andersen
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From this PR: #461
I want to connect to a remote Argo CD instance, and hence I do need the repo-server-address to be explicitly passed in.