Repository navigation
Fix | Deduplicate resources in apps with no destination ns - #490
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The manifest extraction paths returned early when
spec.destination.namespacewas empty. This skipped Argo CD'sDeduplicateTargetObjectsprocessing.Applications containing cluster-scoped resources commonly omit the destination namespace. If such an Application generated the same resource more than once, the duplicate manifests reached the diff engine and were incorrectly reported as additions.
Fix
Always call
DeduplicateTargetObjects, including when the destination namespace is empty.Argo CD then:
This remains scoped to resources within one Application. Resources belonging to different Applications are not deduplicated against each other.
Testing
go test ./pkg/extract/... ./pkg/reposerverextract/...TEST_CASE=\"branch-19/target\" go test -v -timeout 20m -run TestSingleCase -update ./...TEST_CASE=\"branch-19/target\" go test -v -timeout 20m -run TestSingleCase ./...