Conversation
Reference: core/api/LICENCE. Co-Authored-By: Cladius Maximus <cladius@lethean.io>
…block) - git submodule update on external/* to current dev tips - go.work paths fixed for Phase 1 /go/ subtree layout where stale - go.work go-version bumped 1.26.0 → 1.26.2 to match submodule floor Workspace-mode build (`go build ./...`) is the verification path. Some repos may surface transitive dep issues (api/go.sum checksum drift, etc.) which are separate cascade tickets — not blocking this metadata refresh. Co-Authored-By: Cladius Maximus <cladius@lethean.io>
Wires the *RateLimiter surface into Core's service-registration plumbing behind a *core.ServiceRuntime[Config]. NewService() factory builds the limiter via NewWithConfig() and returns a *Service ready for c.Service() registration. Action handlers exposed via OnStartup: ratelimit.check — opts.model + opts.tokens → bool ratelimit.record — opts.model + opts.prompt_tokens + opts.output_tokens ratelimit.stats — opts.model → ModelStats (or full map) ratelimit.decide — opts.model + opts.tokens → Decision ratelimit.reset — opts.model → clear history WaitForCapacity (blocking) + BackgroundPrune (returns cancel func) + Models/Iter (iterators) stay direct method calls — not IPC-friendly. OnShutdown persists state to disk; OnStartup is idempotent via Once. Triplets + examples included; audit verdict COMPLIANT. Co-authored-by: Hephaestus <hephaestus@lthn.ai>
Co-Authored-By: Virgil <virgil@lethean.io>
Advance external/go workspace submodule to v0.10.4 so dev (GOWORK on) and standalone (GOWORK=off) builds resolve the same core/go. Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
This pull request introduces a Core service registration layer for the
ratelimitpackage, enabling it to be used as a first-class service in thedappco.re/goframework. It provides a newServicetype that exposes rate limiting operations (such as check, record, stats, decide, and reset) as Core actions, making integration and orchestration with other services straightforward. The update also includes comprehensive tests and usage examples, upgrades dependencies, and ensures all code is licensed under EUPL-1.2.The most important changes are:
Core Service Integration:
service.goimplementing theratelimit.Servicetype, which wraps a liveRateLimiterand registers action handlers (ratelimit.check,ratelimit.record,ratelimit.stats,ratelimit.decide,ratelimit.reset) for use as a Core service. This design allows consumers to interact with rate limiting through standard Core action plumbing.OnStartupandOnShutdownlifecycle hooks for the service, ensuring action handlers are registered and limiter state is persisted as part of service management.Testing and Examples:
service_test.gowith comprehensive tests for service construction, startup, and shutdown, including edge cases and idempotency checks.service_example_test.gowith usage examples for constructing, starting up, and shutting down the service, demonstrating integration patterns.Dependency and Compatibility Updates:
dappco.re/godependency from v0.9.0 to v0.10.4 and updated the Go version to 1.26.2 for improved compatibility and features. [1] [2] [3]Licensing:
LICENCEfile and ensured all new/modified files include SPDX license headers for compliance. [1] [2] [3] [4]