Skip to content

chore: promote dev to main — go-rag v0.14.0 (Mantis #1245)#7

Merged
Snider merged 1 commit into
mainfrom
dev
Apr 30, 2026
Merged

chore: promote dev to main — go-rag v0.14.0 (Mantis #1245)#7
Snider merged 1 commit into
mainfrom
dev

Conversation

@Snider

@Snider Snider commented Apr 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Brings v0.14.0 to main: refactor(go) drops corelog alias, calls core.Warn directly. Closes Mantis #1245.

Summary by CodeRabbit

  • Chores
    • Internal refactoring of error handling logging mechanism.

@Snider @codex
refactor(go): use core.Warn directly instead of corelog alias (Mantis…
419e9d1 
… #1245)

Drop the `corelog "dappco.re/go/log"` import alias in helpers.go and
call `core.Warn(...)` directly. The log package's Warn forwards to
core; the alias was a layer of indirection.

Three call sites in deferred Qdrant client close handlers (QueryDocs,
IngestDirectory, IngestSingleFile).

Audit (audit.sh) baseline 1585 → 1585 unchanged — corelog→core import
swap isn't a tracked dimension. 0 gaming patterns. Build, vet, test
all clean.

Closes tasks.lthn.sh/view.php?id=1245

Co-authored-by: Codex <noreply@openai.com>
@Snider Snider merged commit f102d40 into main Apr 30, 2026
2 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: add51b77-bdec-43ef-8e2b-ce3696099d37

📥 Commits

Reviewing files that changed from the base of the PR and between 3d42d58 and 419e9d1.

📒 Files selected for processing (1)
  • go/helpers.go
📝 Walkthrough

Walkthrough

The change updates logging in the Qdrant client close operation from corelog.Warn to core.Warn, and removes the now-unused corelog import. No functional changes to control flow.

Changes

Cohort / File(s) Summary
Qdrant client logging update
go/helpers.go		 Changed Qdrant client Close() failure logging from corelog.Warn to core.Warn and removed unused corelog import.

Review rate limit: 3/5 reviews remaining, refill in 18 minutes and 43 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 30, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

sonarqubecloud Bot commented Apr 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Snider