oauth_decode_state fixes - #20
Merged
Merged
Conversation
hmac.compare_digest("", "") is True, so a caller passing an empty stored
token (e.g. session.get("oauth_state", "") on a session miss) would let a
crafted state payload {"n": ""} pass CSRF verification, enabling login
CSRF. An empty expected token now always returns the fallback.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Browsers strip tabs and newlines from URLs before parsing, so a destination like "/\t/evil.com" passed the relative-path check but resolved as the scheme-relative redirect "//evil.com" in the browser. _destination_allowed now rejects any character <= 0x20 alongside backslashes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Closed
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.