layout: add shape: cycle with circular border-trimmed arc routing - #2928
Open
Visio-Vanitas wants to merge 2 commits into
Open
Visio-Vanitas wants to merge 2 commits into
Visio-Vanitas wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
shape: cyclefor circular diagram layouts with circular Bézier arc routing that accurately terminates at visible shape boundaries (fixing #1578, resolving the open constraints from #2362).Implementation Details
Circular Bézier Arc Representation:
Accurate Shape Boundary Trimming:
shape.Shape.Perimeter().Intersections(), accurately snapping the arc entry/exit points to the visible perimeter of diverse shapes (rectangle,circle,cylinder,hexagon, etc.).Cycle Configurations & Nested Container Support:
a.x -> b.y) preserve their relative coordinates and connections during cycle container layout.Testing & Golden Fixtures:
d2layouts/d2cycle/layout_test.gocovering radius computation, single-node safety, nested layout preservation, cross-child descendant routes, and shape diversity.e2etests/txtar.txtunder-- cycle-diagram --. Generated golden.exp.jsonand.exp.svgfiles across Dagre, ELK, and Tala layout engines viaTA=1 ./ci/test.sh ./e2etests -run TestE2E/txtar/cycle-diagram -v(all pass).Closes #1578
/claim #1578