Repository navigation
Offer TALA layout when bundled with d2, and fix edge fill in preview - #166
Open
KhaledQasim wants to merge 2 commits into
Open
KhaledQasim wants to merge 2 commits into
KhaledQasim wants to merge 2 commits into
Conversation
The global `path { fill: ... }` rule in previewPage.html, added to color
the toolbar's zoom/refresh icons, also overrode the fill on the injected
D2 diagram's own paths. Since a CSS rule beats an SVG presentation
attribute, every edge (fill="none") got painted solid instead of staying
stroke-only, corrupting the preview of any diagram with connections.
TALA now ships bundled with d2, so the layout picker only offering it when a standalone `d2plugin-tala` binary is on PATH hid it from most users. Ask d2 directly via `d2 layout`, which lists every engine it can use (bundled or plugin), and keep the PATH check as a fallback.
Author
|
Hello, Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes:
TALA in the layout picker.
D2: Pick Layoutonly offeredtalawhen a standaloned2plugin-talabinary was on PATH. Now that TALA ships bundled with d2, most users never saw the option. The picker now asks d2 viad2 layout, which lists every engine it can use (bundled or plugin), and keeps the PATH check as a fallback.Preview rendering bug. The
path { fill: ... }rule inpreviewPage.html, meant for the toolbar icons, also applied to the diagram's SVG. CSS beats SVG presentation attributes, so edges withfill="none"were painted solid, which broke the preview of any diagram with connections. The rule is now scoped to#toolbar path.Tested with d2 v0.9.0:
talaappears in the picker and previews render correctly.