Use HayWadt ECP for ORCA LANL2DZ#19
Open
oiahoon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LANL2DZ ECPname to ORCA'sHayWadtECP keywordWhy
When LANL2DZ is assigned as a custom basis set for a heavy atom, Basis Set Exchange identifies the matching ECP as
LANL2DZ ECP. The generic name mapping producedLANL2DZECP, which ORCA does not recognize. ORCA documentsHayWadtas the ECP associated with LANL2DZ.The mapping is ORCA-specific, so other package names are unchanged.
Closes #13.
Validation
NewECP Au "LANL2DZECP" endNewECP Au "HayWadt" endThe complete 514-test run passed 490 tests. The remaining 24 pre-existing CLI failures occur because those tests construct unquoted command strings and the local checkout path contains a space; the same 24 failures were present before this change.