Implement event data trb handling#238
Open
Noi0103 wants to merge 9 commits into
Open
Conversation
This is the stepping stone to add event data handling. This should already enable a multi-TRB Data Stage TD.
Noi0103
force-pushed
the
Noi0103/implement-event-data-trb-handling
branch
from
7e322dc to
77e9f72
Compare
The Event Data handle function is more or less copied and it might be good in the future to avoid having 3 times the same code. As is, this seemed simple enough to have it working, in order to advance testing with windows.
Noi0103
force-pushed
the
Noi0103/implement-event-data-trb-handling
branch
from
77e9f72 to
5c81728
Compare
Noi0103
force-pushed
the
Noi0103/implement-event-data-trb-handling
branch
from
5c81728 to
bcd3d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows is never (as far as I saw in logs at least) utilizing the interrupt on completion bit. Windows will instead use event data trb.
The event data appeared on the Control Endpoint and the handler is initially written for the Control Endpoint.
When NormalIn and NormalOut Endpoints also needed event data handling I vendored the handle functions into the respective NormalEndpoint implementations because it seemed easiest. Combining this so that any endpoint can call the same handle_event_data seems better/less error prone.
Should that be added to this PR?