Fix isTestFile, ITE race, hover-tip cleanup, and dialog Enter key#354
Merged
Conversation
Add cd.isTestFile() to identify files whose stem starts or ends with test/tests/spec/steps. Use it to colour filenames steel-blue in the review diff panel and hover-tips, and to simplify inter-test event icons to file_test/file_code. Fix a race where clicking a filename fired saveAnyFileChangesITE asynchronously, allowing a concurrent create/delete/rename/test to use a stale kata.index. The fix locks all CodeMirror editors and gates create/delete/rename/test behind cd.waitForITE(), which polls up to 2s for the in-flight ITE to settle. Clean up hover-tips: remove the traffic-light image and type-marker glyph column; colour filenames by file type. Fix Enter key in the delete file dialog, where the disabled input blocked the keyup handler. Handling moved to dialog-level keydown with event.preventDefault() to suppress browser default submit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cd.isTestFile() to identify files whose stem starts or ends with test/tests/spec/steps. Use it to colour filenames steel-blue in the review diff panel and hover-tips, and to simplify inter-test event icons to file_test/file_code.
Fix a race where clicking a filename fired saveAnyFileChangesITE asynchronously, allowing a concurrent create/delete/rename/test to use a stale kata.index. The fix locks all CodeMirror editors and gates create/delete/rename/test behind cd.waitForITE(), which polls up to 2s for the in-flight ITE to settle.
Clean up hover-tips: remove the traffic-light image and type-marker glyph column; colour filenames by file type.
Fix Enter key in the delete file dialog, where the disabled input blocked the keyup handler. Handling moved to dialog-level keydown with event.preventDefault() to suppress browser default submit.