Remove saver dependency from differ: callers now pass was_files/now_f…#386
Merged
Conversation
…iles directly The differ no longer fetches file contents from saver using (id, was_index, now_index). Callers pass the file contents directly as (was_files:, now_files:). This removes the saver client from the differ entirely, along with all saver-backed test data and the tests that depended on it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Extract was_files as a top-level frozen constant (WAS_FILES) to avoid long escaped string literals that triggered the line-length cop. Collapse Prober#initialize to a single line and suppress Style/RedundantInitialize, which must be kept to satisfy the klass.new(@externals) contract in get_json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meekrosoft
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iles directly
The differ no longer fetches file contents from saver using (id, was_index, now_index). Callers pass the file contents directly as (was_files:, now_files:). This removes the saver client from the differ entirely, along with all saver-backed test data and the tests that depended on it.