Eliminate annotated parameter #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansjoergschurr
approved these changes
Dec 29, 2025
src/type_checker.cpp
Outdated
| // point. | ||
| if (!match(hdt, ctypes[i], ctx, visited)) | ||
| bool isQuote = false; | ||
| bool success = true; |
Collaborator
There was a problem hiding this comment.
is success the right variable name here? maybe there could be a more descriptive name?
Member
Author
|
I've made some updates to simplify things further, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how parameters in
declare-parameterized-constare interpreted.In particular, we determine if the parameter is used in the return type. If yes, we ensure its type is ground. If not, it is treated as an ordinary function argument.
For the former, this disallows a definition like:
This furthermore eliminates ANNOT_PARAM, and adds an additional check to ensure that quoted arguments match the type of the provided argument.
Furthermore removes some unused portions of the code, including type check interface for plugins and the
:requiresannotation for parameters.