Skip to content

revert: keep OpenClaw's native state temporary again - #2

Merged
cv merged 2 commits into
cv:pr/10-skill-pathsfrom
sandl99:revert/openclaw-keep-state
Nov 12, 2026
Merged

cv merged 2 commits into
cv:pr/10-skill-pathsfrom
sandl99:revert/openclaw-keep-state

Conversation

@sandl99

@sandl99 sandl99 commented Nov 12, 2026

Copy link
Copy Markdown

Overview

Reverts #1, which made OpenClaw keep its native state in the agent's state folder with runtime.keep_state, because of the blocker in NVIDIA#626.

The kept folder also keeps OpenClaw's Gateway owner lease, a row in state/openclaw.sqlite. On stop, the adapter sends SIGTERM and force-kills the Gateway after shutdown_timeout_seconds (5 s). In an OpenShell sandbox the Gateway needs about 7 s to release the lease, so the lease is left in the kept state. OpenClaw reclaims a leftover lease only from the same hostname; a replacement Docker sandbox has a new hostname and fails to start with Another Gateway owner lease is still active for this state directory for up to five minutes. With temporary state, the lease is discarded at stop, so replacement starts again.

Details

OpenClaw skill retention returns as a known gap until the shutdown in NVIDIA#626 releases the lease before the force-kill.

Validation

  • pytest tests/adapters/test_openclaw.py tests/adapters/test_openclaw_health.py tests/e2e/test_openclaw_skills.py tests/python/test_adapter_capabilities.py tests/python/test_harness_settings_validation.py: 310 passed, 24 skipped.
  • tests/adapters/test_openclaw.py with the Linux-only mock-Gateway markers lifted on macOS: 138 passed. test_status_command_timeout_stops_children_holding_the_pipes failed once in that run and passed three times alone and in a full rerun.
  • tests/e2e/test_openclaw_skills.py against OpenClaw 2026.9.34: 5 passed.
  • generate_adapter_catalog.py --check, ruff check, the copyright-header hook, and git diff --check.
  • Not run: live OpenClaw replacement on Docker or Kubernetes, the full Python suite, Rust and TypeScript suites (no changes).

Where should the reviewer start?

The conflict resolution in the second commit: adapters/python/openclaw/openclaw.fabric-adapter.json, docs/sdk/python.mdx, and docs/integrations/harness/openclaw/openclaw.mdx.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

This reverts commit f33fa19, which
extends the kept-state start path that the next commit removes.

Signed-off-by: San Dang <sdang@nvidia.com>
This reverts the merge of sandl99/feat/openclaw-keep-state
(8994291), which made the OpenClaw
Gateway use the agent's kept state folder as OPENCLAW_STATE_DIR.

The kept folder also keeps OpenClaw's Gateway owner lease. The adapter
force-kills the Gateway five seconds after SIGTERM, before OpenClaw
releases that lease, and OpenClaw reclaims a leftover lease only on the
same hostname. A replacement sandbox with a new hostname then can't start
for up to five minutes. With temporary state, the lease is discarded at
stop.

The OpenClaw descriptor no longer accepts runtime.keep_state, and the
catalog and docs return to temporary state.

Signed-off-by: San Dang <sdang@nvidia.com>
@sandl99
sandl99 marked this pull request as ready for review November 12, 2026 15:03
@cv
cv merged commit 573e660 into cv:pr/10-skill-paths Nov 12, 2026
37 of 40 checks passed

This branch was successfully deployed

1 active deployment
fern — 5ac4768c Deployed Nov 12, 2026 by cv via Clean up docs preview #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants