Conversation
change_coupling.rb joins cycle_report.rb and reach_through_report.rb as a WIP experiment that is not run in CI, which leaves the Architecture SARIF job with nothing to do, so it goes too. All three were introduced as "WIP anti-pattern experiment tools" (beb2fe8), none graduated into a gem, and none had its findings shown to be worth acting on. The job was spending a full runner - checkout, bundle, ruby setup - on 0.83s of work, and arch-change-coupling had no consumer beyond the SARIF upload itself. If change coupling earns its place it belongs in SlopCop::Bugspots, not in SlopCop::Constraints; the tool header records why. Nothing depended on this job and no aggregator listed it. The three tools and their tests stay in the tree. Co-authored-by: Codex <codex@openai.com>
Two jobs built gems/gigasail with --workspace but install only `giga`. That also builds giga-ui, the axum web UI and LSP server, which `giga` never links: 47 crates exclusive to it (axum, hyper, tower-lsp, askama, rust-embed, rayon and their trees) out of the 212 it needs. giga-ui's binary is referenced nowhere in this workflow. Measured by cleaning exactly those 47 packages and rebuilding, pinned to two cores to match the runner: 3m52s of compilation, 442s of CPU, 222 MB of artifacts. That is the saving in each of the two jobs. cargo llvm-cov for Gigasail keeps --workspace: it measures that workspace's own coverage, so giga-ui belongs in it. Co-authored-by: Codex <codex@openai.com>
Both jobs compiled crates that `sarif-rust-binaries` had already built: nil-kill rebuilt fact-mine and nil-kill, test-miser rebuilt gigasail. Three jobs, one set of binaries. They now download the artifact and install it to the target/release paths their tests resolve, the same way ruby-gems-coverage and fact-mine-rust-coverage already do. No cargo build remains outside the shared job. Waiting on that job is close to free in run time. Measured on run 30694977695: sarif-rust-binaries took 14m06s and is the critical path already - it gates seven jobs and the whole run was 19m - while these two took 4m59s and 6m48s and have no dependents at all. Dropping giga-ui brings the shared job to roughly 10m, after which nil-kill finishes near 12m and test-miser near 15m, both inside the window the shared job's dependents already occupy. Neither job compiles Rust any more, so the rust-toolchain step goes with it; the cargo references left in their suites are mocked (Open3 stubbed to raise ENOENT) or fixture argv, not real invocations. Co-authored-by: Codex <codex@openai.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 92.00% 91.91% -0.09%
==========================================
Files 616 616
Lines 257760 257760
Branches 20024 20024
==========================================
- Hits 237157 236928 -229
- Misses 17472 17701 +229
Partials 3131 3131
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Bencher Report| Project | CLEAR |
| Branch | ci-fixes |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | leak-build-ms | Measure (units) x 1e3 | leak-count | Measure (units) | leak-run-ms | Measure (units) |
|---|---|---|---|---|---|---|
| benchmarks/concurrent/01_socket_throughput/bench | 📈 view plot | 2.32 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 8.42 units |
| benchmarks/concurrent/06_dynamic_spawn/bench | 📈 view plot | 2.20 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 43.05 units |
| benchmarks/concurrent/11_parallel_aggregation/bench | 📈 view plot | 2.15 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 17.89 units |
| benchmarks/concurrent/18_atomic_counter/bench | 📈 view plot | 2.22 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 6.28 units |
| benchmarks/inter-clear/04_concurrent_mvcc_fat_struct/bench | 📈 view plot | 2.24 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 185.00 units |
| benchmarks/sequential/03_alloc_throughput/bench | 📈 view plot | 1.97 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 7.83 units |
| benchmarks/sequential/08_sort/bench | 📈 view plot | 2.13 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 5.83 units |
| benchmarks/sequential/13_soa_layout/bench | 📈 view plot | 2.22 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 692.56 units |
| benchmarks/server/03_pathological/server | 📈 view plot | 2.35 units x 1e3 | 📈 view plot | 0.00 units | 📈 view plot | 1,002.86 units |
Diff Coverage BucketsDiff base:
Src Ruby Visibility BreakdownScope: Files: 213 Counts are nonblank, non-comment Ruby source lines. Protected methods are grouped into
Zig Special Coverage AlertsNo added production Zig lines require missing Loom/VOPR/wait-loop coverage alerts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.