Skip to content

Update to specify broadcastId for triggering broadcast, remove /api in path#179

Merged
washam-cio merged 3 commits into
mainfrom
MESS-710
May 7, 2026
Merged

Update to specify broadcastId for triggering broadcast, remove /api in path#179
washam-cio merged 3 commits into
mainfrom
MESS-710

Conversation

@washam-cio
Copy link
Copy Markdown
Contributor

@washam-cio washam-cio commented May 7, 2026

MESS-710: Update Node SDK broadcast ID support and remove /api path

Updates:

  • This updates api path, removing /api portion
  • Specifies broadcastId, to avoid confusion with campaign ID, which tripped me up.
  • Fixes test that failed in Node 19+ (latest is 25)

Note

Medium Risk
Changes the triggerBroadcast request URL (and its documented parameter naming), which can break integrations relying on the previous /api/campaigns/:id/triggers path. Test adjustment is low risk but the endpoint change affects runtime behavior.

Overview
Updates APIClient.triggerBroadcast to treat the first argument as a broadcast ID (renamed to broadcastId) and to POST to the new endpoint POST /campaigns/:broadcastId/triggers (removing the previous /api/campaigns/... prefix).

Refreshes documentation and unit tests to match the new path, and loosens the bad-JSON parsing assertion in test/request.ts to be compatible with newer Node.js error message variations.

Reviewed by Cursor Bugbot for commit 71b61af. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 84c43bb. Configure here.

Comment thread lib/api.ts
@washam-cio washam-cio merged commit 02d30da into main May 7, 2026
13 checks passed
@washam-cio washam-cio deleted the MESS-710 branch May 7, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants