Conversation
and use them in scan, to get subsecond resolution
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical timestamp parsing and duration calculation errors must be corrected.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds nanosecond-resolution timestamps for subsecond build-time measurement.
Changes:
- Emits nanoseconds at build boundaries.
- Parses nanoseconds when calculating build durations.
| File | Description | Review |
|---|---|---|
single.sh |
Adds nanosecond build timestamps. | No blocking issues identified. |
scan.pl |
Parses timestamps and calculates durations. | Critical: regexes at lines 915, 919, and 921 fail to capture nanoseconds correctly. Critical: line 1029 uses defined-or (//) instead of dividing the nanosecond delta by one billion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| push @confopts, $1; | ||
| } | ||
| elsif(/^(.*) configure non-debug/) { | ||
| elsif(/^(.?*) (\d+|) *configure non-debug/) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and use them in scan, to get subsecond resolution