Conversation
What started out as "stakes", later "markers", is no longer here. It used to be a set value per data-point but it turned out too inflexible and was just never useful. Mean and the moving-mean are the proper values to use.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Marker documentation and dead marker-processing code remain and should be removed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes static performance markers in favor of mean and moving-mean metrics.
Changes:
- Deletes marker configuration and log embedding.
- Removes marker processing and reporting.
- Removes marker graph styling and plotting.
| File | Description |
|---|---|
stakes.conf |
Deletes marker definitions. |
single.sh |
Stops embedding markers in logs. |
scan.pl |
Removes marker processing and output. |
graph.plot |
Removes marker visualization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1004,9 +944,6 @@ sub single { | |||
| elsif(/^confopts: (.*)/) { | |||
| push @confopts, $1; | |||
| } | |||
| push @o, | ||
| sprintf "%u;%s;%s;%s;%s;%s;%s;%.2f\n", $index++, $gitalias{$prevc}, | ||
| $min, $v, $max, $movingav, $bar, mean(@allv); | ||
| $min, $v, $max, $movingav, "", mean(@allv); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What started out as "stakes", later "markers", is no longer here. It used to be a set value per data-point but it turned out too inflexible and was just never useful. Mean and the moving-mean are the proper values to use.