Skip to content

Conversation

@rcabrera-py
Copy link
Contributor

@rcabrera-py rcabrera-py commented Jan 21, 2026

Summary by CodeRabbit

  • New Features

    • User accounts can now be deactivated via the User object.
    • User objects expose a full-name property that concatenates name and surname fields into a single formatted string.
  • Tests

    • Added test coverage validating the full-name behavior.
  • Chores

    • Package version bumped to 2.1.16.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

The User resource class now includes the Deactivable mixin in its inheritance list and exposes a new read-only property full_name that concatenates names, first_surname, and second_surname filtering out empty parts. The package version variable __version__ is updated from '2.1.15' to '2.1.16'. A unit test assertion was added to verify user.full_name equals "José López Hernández".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rogelioLpz
  • alexviquez
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding a full_name property and Deactivable inheritance to the User class, which are the primary modifications across the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8132e1c) to head (ec15955).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         1190      1194    +4     
=========================================
+ Hits          1190      1194    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca/resources/users.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8132e1c...ec15955. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcabrera-py rcabrera-py force-pushed the feat/add-deactivable-and-full-name-property branch from 139d83b to 2178227 Compare January 21, 2026 23:16
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@cuenca/resources/users.py`:
- Around line 98-101: The full_name property can include literal "None" when
names/first_surname/second_surname are missing; update the full_name property to
build the name by collecting names, first_surname, and second_surname, filtering
out None or empty strings, and then joining the remaining parts with a single
space (referencing the full_name property and the attributes names,
first_surname, second_surname); ensure the final result is stripped and returns
an empty string when all parts are absent.

@rogelioLpz rogelioLpz merged commit 318496f into main Jan 22, 2026
18 checks passed
@rogelioLpz rogelioLpz deleted the feat/add-deactivable-and-full-name-property branch January 22, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants