Skip to content

bump to use and support node24 - #17

Merged
mvdan merged 1 commit into
cue-lang:mainfrom
wreulicke:bump-node24
Jul 16, 2026
Merged

mvdan merged 1 commit into
cue-lang:mainfrom
wreulicke:bump-node24

Conversation

@wreulicke

@wreulicke wreulicke commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Bump the action runtime from node20 to node24 in action.cue/action.yml
  • Bump the CI workflow's actions/setup-node step to node-version: 24 in workflows.cue/.github/workflows/build-and-test.yml
  • Re-vendor the GitHub Action JSON Schema (cue cmd vendorgithubschema) so runs.using allows node24, and bump the pinned SchemaStore commit in ci_tool.cue
  • Bump @types/node to 24.13.3 in package.json/package-lock.json
  • Add as const to a test.each array in __tests__/run.test.ts to satisfy the stricter NodeJS.Architecture typing that ships with @types/node@24

Test plan

  • npm run build
  • npm test (14 tests passing)
  • npm run dist (bundle output unchanged aside from type-only deps)
  • cue vet ./...

This PR was created with Claude Code.

Note

  • We are facing deprecations on GitHub Actions.
* Node.js 20 is deprecated on GitHub Actions runners when use this actions.

GitHub Actions runners are forcing workflows that target Node.js 20 to run on Node.js 24 instead. The actions actions/checkout@v4 and actions/setup-node@v4 in this workflow still target Node 20 (from GitHub's side, unrelated to our own node20→node24 bump), which triggers this warning. If Node 20 is temporarily needed, the ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true environment variable can be set. More details: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@wreulicke

Copy link
Copy Markdown
Contributor Author

@myitcv
Hi, could you check this PR?

@mvdan mvdan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM but CI appears to fail, I'll see if I can resolve that.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: wreulicke <12907474+wreulicke@users.noreply.github.com>
@mvdan
mvdan merged commit dbedece into cue-lang:main Jul 16, 2026
2 checks passed
@wreulicke
wreulicke deleted the bump-node24 branch July 17, 2026 00:38
@wreulicke

Copy link
Copy Markdown
Contributor Author

SGTM but CI appears to fail, I'll see if I can resolve that.

@mvdan
Thank you for your response. I'm looking forward to release this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants