[daantimmer]

🤔 What's changed?

• Added C++ implementation for Query

⚡️ What's your motivation?

• There was none

🏷️ What kind of change is this?

• ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

[mpkorstanje]

Okay, no problem.

All the packages that we depend on are available in system packages, so I am updating the test builds to use those available to linux, macos and windows. The downside is we don't have control over the exact installed packages, OTOH, if the tests work with an older version than that should be fine too.

I'd prefer it if we did depend on a specific version. Waiting for system packages is a bit too slow too make a comfortable feedback cycle.

But we should depend on a specific version, not a hash. and Renovate should be able to update that. We've done that before so I hope we can reuse that mechanism.

[daantimmer]

@mpkorstanje I request your assistance in setting up:

• renovate
• VERSION release updates

[mpkorstanje]

@mpkorstanje I request your assistance in setting up:

* renovate

* VERSION release updates

The VERSION file can be updated by polyglot-release. So that happens automatically as part of the release process.

What I'm missing though for Renovate is a specific file where the dependencies are declared. We had something like this in messages (https://github.com/cucumber/messages/blob/90a083420143561f4fab39528519ee858d1b35a1/cpp/cmake/dependencies.cpm.cmake).

The closest thing that resembles this would be https://github.com/cucumber/query/blob/feature%2Fcpp/cpp/cmake/cucumber_query-config.cmake.in, but I don't see any hashes or version numbers there. I also see a find_package and find_dependency. So to me it is not immediately where and how you fetch the dependencies.