remove cmate in favour of native CMake + CPM#432
Draft
daantimmer wants to merge 8 commits into
Draft
Conversation
Update cpp.hpp.erb codegen to indent properly Update cpp.hpp.erb to treat all functions equal on where the return type goes (same line instead of separate line)
…. Setup MSVC dev for windows only
…native-cmake-and-CPM
…lify build process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
The custom cmate script adds no value and only confusion on maintaining the cpp codebase. Secondly its an unmaintained script by a third party.
As for the codegen, there were some inconsistencies.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I am not too sure about the separation of generated vs non-generated code. It makes reading and maintaining a lot easier. However it does mean that this is a very large change because of all the file moves.
Regarding the checklist's
#pragma oncetodo item. This is a highly debated topic in C++ land. However as a public library we should follow the core guidelines as closely as possible, and thus follow the rule: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf8-use-include-guards-for-all-header-filesI can, if preferred, do this in a separate pull request.
On that note I'll also add tooling (in a separate PR) to check for compliancy with the c++ core guidelines.
📋 Checklist:
#pragma oncewith proper include guards.This text was originally generated from a template, then edited by hand. You can modify the template here.