Open
Conversation
patriciaahuang
force-pushed
the
update-search
branch
from
4191fcd to
e78da04
Compare
patriciaahuang
force-pushed
the
update-search
branch
from
e78da04 to
a0209d6
Compare
joycrwu
reviewed
Nov 4, 2023
|
|
||
| class SearchView(generics.GenericAPIView): | ||
| serializer_class = RideSerializer | ||
| permission_classes = api_settings.CONSUMER_PERMISSIONS |
Contributor
There was a problem hiding this comment.
why did we get rid of these permission classes?
added 2 commits
November 8, 2023 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implemented an extension to the previous search endpoint, so a user can specify what time range they want to search between.
Changes Made
I updated the search endpoint to include two more parameters (daysbefore and daysafter) so the user can specify how long before and after their exact departure date they would want to search rides.
Test Coverage
Using Postman, I created rides that were within the specified time range and outside the specified time range, and made sure
/api/search/search/depart/str:depart/daysbefore/int:daysbefore/daysafter/int:daysafter/start/str:start/end/str:end/radius/int:radius/
returned only the rides within the time frame specified by the parameters.