Open
Conversation
alanna-zhou
approved these changes
May 2, 2021
Contributor
alanna-zhou
left a comment
alanna-zhou
left a comment
There was a problem hiding this comment.
nice! should probs update the PR title so when u merge in the commit name makes sense :p
| return session.serialize_session_v2() | ||
|
|
||
| except ValueError: | ||
| raise Exception("Invalid token") |
Contributor
There was a problem hiding this comment.
hm wouldnt people debugging want to know the reason behind the invalid token
|
|
||
| # DEPRECATED!!!! | ||
| # NONE is a constant imported from constants.py with string value "None" | ||
| # Following line of code converts the NONE="None" string value into Python's null value None |
Contributor
There was a problem hiding this comment.
interesting i did not know this haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
New notifications flow implemented in v2 api
Changes Made
MOBILE || EMAILinstead ofIOS || ANDROID || WEB || NONEI hope it works :)
TODO
Have to migrate notification column on prod db from
IOS || ANDROIDtoMOBILEUpdate env var