Fixed permission for the exported keys and certificates

[ctyano]

Type of changes

Choose one of the below, or leave them empty:

• New feature proposal
• Bug fix
• Minor improvements
• Refactoring (no functional changes)
• Non-code changes (updating documentation, workflows, etc.)

[gemini-code-assist]

Summary of Changes

Hello @ctyano, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug related to file permissions for cryptographic assets. By explicitly setting the ownership of generated CA, server, and client certificates and their corresponding private keys, it ensures that these sensitive files are accessible only by the designated user and group, thereby enhancing the security and operational integrity of the system.

Highlights

• File Permissions: A chown command has been added to init_hsm.sh to explicitly set the ownership of all generated CA, server, and client certificate and key files to 10001:1001.
• Bug Fix: This change resolves a bug where exported keys and certificates might have incorrect permissions, potentially preventing proper access by the intended user or group.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an important issue by changing the ownership of generated keys and certificates. My review focuses on improving the maintainability and security of this change. I've suggested using variables for the user and group IDs to avoid hardcoded values, and more importantly, to tighten the file permissions on the private keys to prevent them from being world-readable. This is a critical security improvement.

[gemini-code-assist]

This line hardcodes the UID and GID, which is not ideal for maintainability. It's better to use variables that can be set via environment variables. Additionally, the permissions on the generated key files are too open (-rw-r--r--), making them world-readable. This is a security concern, as private keys should only be readable by their owner. The permissions should be tightened.

Suggested change

	chown 10001:1001 ${CACERT_FILE} ${SERVERCERT_KEY_FILE} ${SERVERCERT_FILE} ${CLIENTCERT_KEY_FILE} ${CLIENTCERT_FILE}
	chown "${CRYPKI_UID:-10001}:${CRYPKI_GID:-1001}" ${CACERT_FILE} ${SERVERCERT_KEY_FILE} ${SERVERCERT_FILE} ${CLIENTCERT_KEY_FILE} ${CLIENTCERT_FILE}
	chmod 640 ${CACERT_FILE} ${SERVERCERT_FILE} ${CLIENTCERT_FILE}
	chmod 600 ${SERVERCERT_KEY_FILE} ${CLIENTCERT_KEY_FILE}