Skip to content

Fix open Dependabot and CodeQL security findings - #14

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/security-alert-fixes-6953
Oct 19, 2026
Merged

cursor[bot] merged 1 commit into
mainfrom
cursor/security-alert-fixes-6953

Conversation

@ctopherwilliams

Copy link
Copy Markdown
Owner

Summary

Clears the dependency and CodeQL findings that have a real fix, without dismissing anything.

  • Override transitive dev dependencies to patched releases:
  • Replace Math.random fallbacks used for session, document, producer, writer-lease, auction-token, and transition-owner ids with crypto.randomUUID, falling back to crypto.getRandomValues.
  • Escape values pasted into the visual-certification Chrome DevTools expressions after JSON.stringify, so <, >, /, and U+2028/U+2029 cannot break out of the evaluated script.
  • Rebuild companion 0.2.34 so the checked-in package matches the extension source.

The Dependabot and code-scanning list APIs returned 403 for this token. The dependency set above is everything npm audit reports from the GitHub advisory database with a patched version. That includes Dependabot alert #22 (sharp).

Still open

  • braces <=3.0.3 (GHSA-vfj7-8cjw-p6xm) has no patched release (3.0.3 is still the latest). It remains a transitive dev dependency through micromatch. This is a real advisory, so it is not dismissed.
  • tests/workspace-handshake-integration.test.mjs still uses Math.random only to bust a dynamic import() cache. That value is not an id, token, or nonce, so it was left in place.

Verification

  • npm ci with npm 11.16.0 on Node 24.18.0
  • npm run check: lint, typecheck, build, and 767 tests passed
  • npm run test:live-control: passed, including the 11 visual scenarios
Open in Web Open in Cursor 

Override sharp, undici, fast-uri, and js-yaml to patched releases.
Mint session, lease, and request identifiers with a CSPRNG, and
escape values embedded in visual-certification JavaScript.

Co-authored-by: Chris Williams <ctopherwilliams@users.noreply.github.com>
@cursor
cursor Bot merged commit 367cc01 into main Oct 19, 2026
5 checks passed
@cursor
cursor Bot deleted the cursor/security-alert-fixes-6953 branch October 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants