Repository navigation
Fix open Dependabot and CodeQL security findings - #14
Merged
Merged
Conversation
Override sharp, undici, fast-uri, and js-yaml to patched releases. Mint session, lease, and request identifiers with a CSPRNG, and escape values embedded in visual-certification JavaScript. Co-authored-by: Chris Williams <ctopherwilliams@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the dependency and CodeQL findings that have a real fix, without dismissing anything.
sharp0.35.5 (GHSA-wq5f-xc86-pv6w, and the libheif advisory GHSA-rgj7-g3m4-5g8c)undici7.29.1 (the 7.29.0 advisories, including GHSA-w293-vg96-wgc3 and GHSA-rfgv-xxqx-mfg5)fast-uri3.1.8 (GHSA-hrr3-gc8f-f4qj)js-yaml4.3.2 (GHSA-2883-xcg3-v3hh)Math.randomfallbacks used for session, document, producer, writer-lease, auction-token, and transition-owner ids withcrypto.randomUUID, falling back tocrypto.getRandomValues.JSON.stringify, so<,>,/, and U+2028/U+2029 cannot break out of the evaluated script.The Dependabot and code-scanning list APIs returned 403 for this token. The dependency set above is everything
npm auditreports from the GitHub advisory database with a patched version. That includes Dependabot alert #22 (sharp).Still open
braces<=3.0.3(GHSA-vfj7-8cjw-p6xm) has no patched release (3.0.3is still the latest). It remains a transitive dev dependency throughmicromatch. This is a real advisory, so it is not dismissed.tests/workspace-handshake-integration.test.mjsstill usesMath.randomonly to bust a dynamicimport()cache. That value is not an id, token, or nonce, so it was left in place.Verification
npm ciwith npm 11.16.0 on Node 24.18.0npm run check: lint, typecheck, build, and 767 tests passednpm run test:live-control: passed, including the 11 visual scenarios