Updated Frontend to use Query Service Files#243
Merged
Conversation
VidurShah
changed the title
…etQueryData call before invalidate Queries to avoid overwrite issues
naasanov
requested changes
Mar 4, 2026
Collaborator
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
Looks great so far. Just missing some optimistic update opportunities and nice to haves with query key management. Lmk if you have any questions about expectations
naasanov
requested changes
Mar 24, 2026
Collaborator
naasanov
left a comment
naasanov
left a comment
There was a problem hiding this comment.
I'm just going through all outstanding PRs. Just waiting on merge conflicts
Removed unnecessary import statements for LocationCreate and LocationDto.
…into pr/VidurShah/243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, query hooks were defined within the components. For cleanliness, reusability, and proper layer abstraction, moved the definition of these queries to their own services in
libChanges:
Closes #119