fix: clean up example fragment markup and smoke inventory#795
Conversation
ab215eb to
31c077b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c083f09cc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| page dashboard | ||
| route "/dashboard" | ||
| guard public | ||
| guard auth.required |
There was a problem hiding this comment.
Ensure direct login builds install the guard hook
When this page switches to the custom auth.required guard, the generated app requires GOWDKGuardRegistry; I checked the documented clean-tree command go run ../../cmd/gowdk build --target login in examples/login/README.md and it now fails with undefined: GOWDKGuardRegistry because only the Makefile copies apphooks/login_hooks.go.txt into .gowdk/.../gowdkapp. Either update the direct commands to create/copy the hook first or route users to make build/make split-build so the example remains reproducible from a clean checkout.
Useful? React with 👍 / 👎.
| server { | ||
| => { session.email, session.expiresAt } |
There was a problem hiding this comment.
Keep split login builds compiling with SSR load data
With this new server {} dashboard, the split target now generates frontend SSR code that calls auth.LoadDashboard, but the generated frontend app does not import the auth package. I checked make split-build from a clean examples/login tree and it fails while compiling .gowdk/login-frontend/gowdkapp/app.go with undefined: auth, so the advertised split example cannot build until the split frontend gets the bound SSR load import or the dashboard is kept out of that target.
Useful? React with 👍 / 👎.
0f25bec to
ef47e20
Compare
ef47e20 to
eb0937d
Compare
Summary
html/templatefiles.examples/smoke-sources.txtas the shared source of truth for broad example report checks.examples/auth-guard.form.Datahandlers do not emit an unusedvaluesdeclaration.CI / PR titleand a leanCI / Verifygate, with superseded CI runs cancelled automatically.Issue Closure
Fixes #760
Fixes #761
Fixes #762
Fixes #763
Verification
scripts/test-go-modules.shwhen Go code or compiler behavior changed.go build ./cmd/gowdkwhen CLI, compiler, runtime, addon, or release behavior changed.node --check editors/vscode/extension.jswhen editor files changed. Covered by the leanVerifyworkflow step; no editor files changed locally.Commands run locally:
go test ./internal/appgengo test ./examples/endpoints/src/endpoints ./examples/flagship/src/app ./examples/login/src/features/authgo test ./internal/gowdkcmd -run TestReleaseTrustWorkflowCoveragego test ./internal/gowdkcmdgo test ./...(cd examples/login && rm -rf .gowdk bin dist && go run ../../cmd/gowdk build && go test ./src/features/auth)(cd examples/login && rm -rf .gowdk bin dist && go run ../../cmd/gowdk build --target login && rm -rf .gowdk bin dist && make split-build)sh scripts/check-example-reports.shgo build ./cmd/gowdkscripts/test-go-modules.shsh scripts/check-docs-style.shsh scripts/check-docs-links.shgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/ci.ymlNote:
scripts/check-example-reports.shstill prints existing accessibility/button warnings, andscripts/check-docs-style.shstill prints existing long-paragraph warnings; both exited 0.LLM Assistance
main, fixed stale release workflow coverage, restored the login example to directgowdk buildcompatibility, and reduced PR CI to a lean title plus verify setup.examples/auth-guard; routine PR checks should stay small and avoid expensive audit/fuzz/race/dead-code/generated-output matrix gates.PR titleandVerifyinstead of the previous individual CI job names.