Adding interpol.jl, hyperbolic1D.jl and edit on Operators.jl#340
Adding interpol.jl, hyperbolic1D.jl and edit on Operators.jl#340jlbaranda wants to merge 18 commits into
Conversation
|
Hi @jlbaranda , your PR shows the warning Please sync your branch with the latest upstream |
|
Hello @jlbaranda we are planning to tag a new release of MOLE very soon (tomorrow). If you would like your contribution to be included (which would be very nice) please address my comments as soon as possible. Thank you! |
|
Hey @valeriabarra, I won't be able to finish my contribution until after 05/14/2026 due to prior commitments and finals. Thanks for keeping me updated and I appreciate all the constructive feedback. |
Hello @jlbaranda , are you able to address the comments now? |
Yes, I have been working on it today, I noticed the second comment involves me building the function to remove the global variable use, (coding best practice). I am currently stuck there but I think I could manage. |
Okay, |
|
Hello @jlbaranda , please let me know if you can update this soon or need assistance. Happy to help. Thank you! |
|
Hi @jlbaranda, I would like to help speed up this PR so that we can merge it soon. If you can't update it at this time, I could help by directly pushing to your branch. Please let me know if you are OK with me pushing to your branch. Thank you |
jlbaranda
force-pushed
the
interpolator_branch2
branch
from
bc23ceb to
41f7396
Compare
Hey @valeriabarra , thanks for your patience, I have updated the Julia files to fix the comments on the animations and also saving the outputs for both hyperbolic1D.jl and burgers1D.jl. I still need to work on the documentation. Please let me know if there are any more changes I need to do the Julia files. I plan to work on the documentation portion after work. |
|
Hi @jlbaranda , in addition to my other comment, please remove the |
|
Hi @valeriabarra, I have removed the output folder from the PR and modified the docs index file to include the interpol operator. Let me know if there is anything I need to add or adjust. Thanks again for your prompt replies!! |
|
Hi @jlbaranda , in addition to my Review comment, please note that the |
…, and its index.md
jlbaranda
force-pushed
the
interpolator_branch2
branch
from
9fee09b to
f9514bc
Compare
Hey @valeriabarra, I have updated my fork and PR branch, and have tested the compiling for the documents locally. Let me know if there is anything I need to add or adjust. I greatly appreciate your reviews!! |
Looks good, thank you! |
| #= | ||
| @testset "Testing interpolating operator for m=5 and c=0.5" begin | ||
| m = 5 | ||
| c = 0.5 | ||
| I = Operators.interpol(m,c) | ||
| A = [1 0 0 0 0 0 0; | ||
| 0 0.5 0.5 0 0 0 0; | ||
| 0 0 0.5 0.5 0 0 0; | ||
| 0 0 0 0.5 0.5 0 0; | ||
| 0 0 0 0 0.5 0.5 0; | ||
| 0 0 0 0 0 0 1] | ||
| @test norm(I-A) < tol | ||
| end | ||
|
|
||
|
|
||
| @testset "Testing interpolating operator for m=5 and c=1" begin | ||
| m = 5 | ||
| c = 1.0 | ||
| I = Operators.interpol(m,c) | ||
| A = [1 0 0 0 0 0 0; | ||
| 0 1 0 0 0 0 0; | ||
| 0 0 1 0 0 0 0; | ||
| 0 0 0 1 0 0 0; | ||
| 0 0 0 0 1 0 0; | ||
| 0 0 0 0 0 0 1] | ||
| @test norm(I-A) < tol | ||
| end | ||
| =# |
There was a problem hiding this comment.
Hi @jlbaranda , did you intend to comment/hide these tests?
3 participants
What type of PR is this? (check all applicable)
Description
This would replace #332 and be subsided and would be this one instead
Related Issues & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
_We encourage you to test all code included with MOLE, including examples.
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?