Allow inverse (negative timestep) or instantaneous (0 timestep) models#49
Open
dorchard wants to merge 2 commits intocsdms:masterfrom
Open
Allow inverse (negative timestep) or instantaneous (0 timestep) models#49dorchard wants to merge 2 commits intocsdms:masterfrom
dorchard wants to merge 2 commits intocsdms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows two new classes of model:
This PR generalises the tests that (previously) checked that the current time is <= the start and <= the end (now it can be the opposite if the time step is negative, or it can be the same if the time step is 0- this is redundandtly broken into its own case but for clarity). Similarly it generalises the tests checking the relationship between the start and end.
This has been tested on pymt_hydrotrend.
(see discussion here: https://github.com/orgs/csdms/discussions/26)