Skip to content

Fix draft release ID lookup before signing #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csd113 merged 1 commit into from
Oct 1, 2026
Merged

Fix draft release ID lookup before signing #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,16 @@ jobs:
fi
gh release create "$GITHUB_REF_NAME" --draft --title "Release $GITHUB_REF_NAME" --notes-file RELEASE_NOTES.md
fi
release_id="$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$GITHUB_REF_NAME" --jq '.id')"
release_id="$(gh api graphql \
-f owner="$GITHUB_REPOSITORY_OWNER" \
-f name="${GITHUB_REPOSITORY#*/}" \
-f tag="$GITHUB_REF_NAME" \
-f query='query($owner: String!, $name: String!, $tag: String!) { repository(owner: $owner, name: $name) { release(tagName: $tag) { databaseId isDraft } } }' \
--jq '.data.repository.release | select(.isDraft) | .databaseId')"
if [[ ! "$release_id" =~ ^[1-9][0-9]*$ ]]; then
echo "Expected a draft release with a positive numeric ID" >&2
exit 1
fi
python3 tools/update_package.py sign --directory release-assets --key "$key_file" --release-id "$release_id" --version "$GITHUB_REF_NAME"
rm release-assets/build-info-*.json

Expand Down
Loading