Add option to upload semicolon separated csv files in metadata import step#451
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
jorisfu
requested changes
Jun 3, 2026
Collaborator
jorisfu
left a comment
There was a problem hiding this comment.
Generally agree but I think we should make this more general, maybe add a dropdown with comma, tab, and semicolon, should be fairly simple to pass to the sep argument
Collaborator
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #450
We now have a checkbox that the user has to unselect to upload a semicolon separated csv.
Changes
Changed the file import and the form for the metadata upload.
Testing
Create a standard workflow and upload the semicolon separated csv which you can find in the nextcloud.
Of course, make sure to unselect the comma separated checkbox.
PR checklist
Development
Mergeability
blackpnpm formatand checked withpnpm lintCode review