Skip to content

Add option to upload semicolon separated csv files in metadata import step#451

Merged
Elena-kal merged 6 commits into
devfrom
450-semicolon-separated-upload-option
Jun 5, 2026
Merged

Add option to upload semicolon separated csv files in metadata import step#451
Elena-kal merged 6 commits into
devfrom
450-semicolon-separated-upload-option

Conversation

@Elena-kal
Copy link
Copy Markdown
Collaborator

@Elena-kal Elena-kal commented Jun 3, 2026

Description

fixes #450
We now have a checkbox that the user has to unselect to upload a semicolon separated csv.

Changes

Changed the file import and the form for the metadata upload.

Testing

Create a standard workflow and upload the semicolon separated csv which you can find in the nextcloud.
Of course, make sure to unselect the comma separated checkbox.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The backend code has been formatted with black
  • The frontend code has been formatted with pnpm format and checked with pnpm lint

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@Elena-kal Elena-kal requested a review from jorisfu June 3, 2026 13:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  backend/protzilla/importing
  example_dataset_import.py
  metadata_import.py 24-29, 65, 120-121
  backend/protzilla/methods
  importing.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Copy Markdown
Collaborator

@jorisfu jorisfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally agree but I think we should make this more general, maybe add a dropdown with comma, tab, and semicolon, should be fairly simple to pass to the sep argument

@Elena-kal Elena-kal requested a review from jorisfu June 3, 2026 17:11
@Elena-kal
Copy link
Copy Markdown
Collaborator Author

Generally agree but I think we should make this more general, maybe add a dropdown with comma, tab, and semicolon, should be fairly simple to pass to the sep argument

Done

Copy link
Copy Markdown
Collaborator

@jorisfu jorisfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@Elena-kal Elena-kal merged commit e56aa4e into dev Jun 5, 2026
1 check passed
@Elena-kal Elena-kal deleted the 450-semicolon-separated-upload-option branch June 5, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants