fix(vyper): model loop bounds and range arguments correctly - #3085
Open
zloglevel wants to merge 1 commit into
Open
fix(vyper): model loop bounds and range arguments correctly#3085zloglevel wants to merge 1 commit into
zloglevel wants to merge 1 commit into
Conversation
Signed-off-by: zloglevel <loglevel@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Vyper loop modeling in the CFG and SlithIR generation.
Root Cause
Vyper loops were modeled with an inclusive upper bound:
This caused one extra modeled iteration and could produce an invalid access at
iterable[len(iterable)].For two-argument
range(start, end), Slither also initialized the artificial counter to0and used the first argument as the endpoint. This did not match Vyper's half-open range semantics.Changes
counter_var < len(iterable)for array iteration.counter_var < endforrange(end).startforrange(start, end).boundkeyword behavior without treating it as the range endpoint.Testing