feat: Added chain generating for debank apps#251
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds chain attribution for DeBank “apps” parsing and switches deposit token parsing to a typed token model so downstream consumers can reliably access token fields.
Changes:
- Introduced
DEBANK_APP_CHAIN_MAPand used it to populate achain: Blockchainfield on parsedDebankPredictionandDebankAppDeposit. - Replaced raw
dicttoken handling for app deposits with a new typedDebankDepositTokenmodel and updated parsing to useasset_token_list. - Updated app parser tests to assert chain and typed token access.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
blockapi/v2/models.py |
Adds DebankDepositToken, types app deposit tokens, and adds chain to app-level parsed models. |
blockapi/v2/api/debank_maps.py |
Adds an app-id → chain mapping used during app parsing. |
blockapi/v2/api/debank.py |
Threads chain through app parsing into deposits and predictions; switches deposit token extraction to asset_token_list. |
blockapi/test/v2/api/debank/test_debank_fetch.py |
Adds an integration test stub for fetching apps (but currently not asserting). |
blockapi/test/v2/api/debank/test_debank_app_parser.py |
Extends parser tests to assert chain and typed token access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e0ae7ed to
cd5799f
Compare
galvanizze
reviewed
Feb 4, 2026
galvanizze
approved these changes
Feb 5, 2026
galvanizze
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.