Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tx.GetField()callscol.FindAll()for every rule × every variable it targets. Each call builds afresh
[]corazarules.MatchData+[]types.MatchDataholding every entry of the collection:Map.FindAll/NamedCollectionNames.FindAll: two allocations of size n per call.ConcatKeyed.FindAll/ConcatCollection.FindAll(ARGS=ARGS_GET+ARGS_POST,ARGS_NAMES, …):calls the children's
FindAll, rewritesVariable_on the results in place (replaceVariable),and grows the result with repeated
append.Within a phase the collections don't change, so this is the same copy rebuilt hundreds of times.
Cost is O(rules × args): with CRS, a 16KB JSON body (~600 ARGS) allocated ~20MB per request, and
madvise+memclr+ GC were ~40–50% of CPU.GetFieldalso lowercases every match's key (strings.ToLower(c.Key())) even when the rule has noexceptions, and compacts the slice in place.