Skip to content

macro expand: log at debug level if the variable was not found #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blotus merged 2 commits into from
Jul 29, 2026
Merged

macro expand: log at debug level if the variable was not found #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a454f
macro expand: log at debug level if the variable was not found
blotus Jul 29, 2026
42be06a
fix tests
blotus Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/plugins/macro/macro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func expandToken(tx plugintypes.TransactionState, token macroToken) string {
}

// If the variable is known (e.g. TX) but the key is not found, we return the original text
tx.DebugLogger().Warn().Str("variable", token.variable.Name()).Str("key", token.key).Msg("key not found in collection, returning the original text")
tx.DebugLogger().Debug().Str("variable", token.variable.Name()).Str("key", token.key).Msg("key not found in collection, returning the original text")
return token.text
}

Expand Down
10 changes: 9 additions & 1 deletion internal/actions/setvar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,56 +67,64 @@ func TestSetvarEvaluate(t *testing.T) {
init2 string
expectInvalidSyntaxError bool
expectNewVarValue string
logLevel debuglog.Level
}{
{
name: "Numerical operation + with existing variable",
init: "TX.var=5",
init2: "TX.newvar=+%{tx.var}",
expectInvalidSyntaxError: false,
expectNewVarValue: "5",
logLevel: debuglog.LevelError,
},
{
name: "Numerical operation - with existing variable",
init: "TX.var=5",
init2: "TX.newvar=-%{tx.var}",
expectInvalidSyntaxError: false,
expectNewVarValue: "-5",
logLevel: debuglog.LevelError,
},
{
name: "Numerical operation - with existing negative variable",
init: "TX.newvar=-5",
init2: "TX.newvar=+5",
expectInvalidSyntaxError: false,
expectNewVarValue: "0",
logLevel: debuglog.LevelError,
},
{
name: "Numerical operation + with missing (or non-numerical) variable",
init: "TX.newvar=+%{tx.missingvar}",
expectInvalidSyntaxError: true,
logLevel: debuglog.LevelDebug,
},
{
name: "Numerical operation - with missing (or non-numerical) variable",
init: "TX.newvar=-%{tx.missingvar}",
expectInvalidSyntaxError: true,
logLevel: debuglog.LevelDebug,
},
{
name: "Non Numerical Operation - If the value starts with -",
init: "TX.newvar=----expected_value",
expectInvalidSyntaxError: false,
expectNewVarValue: "----expected_value",
logLevel: debuglog.LevelError,
},
{
name: "Non Numerical Operation - If the value starts with +",
init: "TX.newvar=+++expected_value",
expectInvalidSyntaxError: false,
expectNewVarValue: "+++expected_value",
logLevel: debuglog.LevelError,
},
}

for _, tt := range tests {
logsBuf := &bytes.Buffer{}

logger := debuglog.Default().WithLevel(debuglog.LevelWarn).WithOutput(logsBuf)
logger := debuglog.Default().WithLevel(tt.logLevel).WithOutput(logsBuf)

t.Run(tt.name, func(t *testing.T) {
defer logsBuf.Reset()
Expand Down
Loading