FIX=> Add Cancellation Reason for offer in preload data #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulsayyad123
requested review from
abhinav098,
namrataukirde,
patrixr,
shreyas098 and
swatijadhav
namrataukirde
approved these changes
Feb 13, 2020
patrixr
reviewed
Feb 14, 2020
| } | ||
|
|
||
| if (this.get("session.authToken")) { | ||
| promises = promises.concat( |
Member
There was a problem hiding this comment.
shouldn't this be outside of the if (this.get("session.authToken")) condition ?
What happens if you load the app, and then log-in ? Won't those records be missing ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
This PR is for adding filtered Cancellation Reason for Offers in Admin app. This change is related to latest changes in "Cancellation Reason" table.
Please review this PR and let me know if any change is required.
Thanks