Repository navigation
revert: "feat(sdk): serve any named gRPC service" - #4
Merged
Merged
Conversation
Reverts #1, keeping serve as the only server entry point. A project that needs a customized server (a custom codec, caller-owned health) builds it from public pieces - tonic, tonic-health, tonic-reflection and proto::FILE_DESCRIPTOR_SET - as function-wasm did before #1. An SDK-side abstraction cannot anticipate the next customization and had exactly one caller; the minimal surface wins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1 (unreleased), keeping
serveas the SDK's only server entry point.The customization question resolved the other way: a project that needs a customized server - a custom codec, caller-owned health, extra services - can build one entirely from public pieces (tonic, tonic-health, tonic-reflection,
proto::FILE_DESCRIPTOR_SET), which is exactly what function-wasm did before #1 and returns to now. The transport glue is ~50 stable lines; an SDK-side abstraction (#1'sserve_service, #2's health variant, #3's builder) kept growing to chase one caller's needs and still could not anticipate the next one. The minimal surface wins; #2 and #3 are closed for the same reason.