[fernandezcuesta]

Description of your changes

Fixes #394

Pass --use-default-kwarg to datamodel-code-generator so it writes field defaults with the default= keyword, as in Field(default=None, alias='continue').

Pyright and Pylance read defaults only from that keyword, so they reported these fields as required. They now treat them as optional.

Reproduced with the pinned datamodel-code-generator:0.59.0 image and the CLI's arguments, on a minimal OpenAPI spec with the two cases from #394 (a field renamed from a Python keyword, and an object field with a {} default).

Generated models, without and with --use-default-kwarg:

class ListMeta(BaseModel):
-    continue_: str | None = Field(None, alias='continue')
+    continue_: str | None = Field(default=None, alias='continue')

class Widget(BaseModel):
name: str
-    metadata: ObjectMeta | None = Field({}, validate_default=True)
+    metadata: ObjectMeta | None = Field(default={}, validate_default=True)

Type-checking this script with pyright 1.1.406:

from models.api import ListMeta, Widget

ListMeta()
Widget(name="w")

Before:

t.py:3:1 - error: Argument missing for parameter "continue" (reportCallIssue)
t.py:4:1 - error: Argument missing for parameter "metadata" (reportCallIssue)
2 errors, 0 warnings, 0 informations

After:

0 errors, 0 warnings, 0 informations

---

I have:

• Read and followed Crossplane's contribution process.
• Run ./nix.sh flake check to ensure this PR is ready for review.
  - [ ] Added or updated unit tests.
  - [ ] Linked a PR or a docs tracking issue to document this change.
  - [ ] Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: crossplane/cli
• Branch: main
• File: .coderabbit.yaml
• Commit: ddf8dd2
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8bef5c86-d6ac-4cdd-bde6-7956b489044b

Commits

Reviewing files that changed from the base of the PR and between ddf8dd2 and 8e5834b.

Files selected for processing: 1

• internal/schemas/generator/python.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}