[jcogilvie]

Description of your changes

Adds the render.crossplane.io/session label to every Docker container and network crossplane render creates, completing the label set proposed in #401 (managed-by and cleanup landed in #407).

Callers can supply the session ID, so many renders in one process (or concurrent runs) can each own a distinct session and clean up only their own resources:

• CLI / library: EngineFlags.SessionID (--session-id). The engine applies it to the network and engine container it creates, and annotates Functions in Setup (both the Docker and local-binary engines) so Function containers carry it too.
• Per Function: the new render.crossplane.io/runtime-docker-session annotation (RuntimeDocker.Session). An annotation already on a Function is never overwritten.
• If no ID is supplied, a random ID is generated and used as the fallback. It is shared by everything in the process that was not given an ID, so callers running independent renders should supply their own.

Not included: the optional created-by-pid label and a render cleanup subcommand.

Part of #401

I have:

• Read and followed Crossplane's contribution process.
• Run go test ./cmd/crossplane/render/....

🤖 Generated with Claude Code

[haarchri]

nice!

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: crossplane/cli/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0f48db54-1abd-48fa-98bd-74c36913754d

📥 Commits

Reviewing files that changed from the base of the PR and between c6b004c and c61fed7.

📒 Files selected for processing: 10

• cmd/crossplane/render/engine.go
• cmd/crossplane/render/engine_docker.go
• cmd/crossplane/render/engine_docker_test.go
• cmd/crossplane/render/engine_local.go
• cmd/crossplane/render/network.go
• cmd/crossplane/render/network_test.go
• cmd/crossplane/render/render.go
• cmd/crossplane/render/runtime_docker.go
• cmd/crossplane/render/runtime_docker_test.go
• cmd/crossplane/render/session_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Render engines now carry session IDs into Function annotations and Docker resource labels. If no session ID is supplied, Docker labeling uses a stable process-wide ID. Both Docker and local engine setup annotate Functions.

Changes: Render session labels

Layer / File(s)	Summary
Session ID and runtime labels cmd/crossplane/render/runtime_docker.go, cmd/crossplane/render/runtime_docker_test.go, cmd/crossplane/render/session_test.go	Runtime Docker configuration reads the session annotation and applies session labels. An empty session uses a stable process-wide ID. Tests cover supplied and default IDs.
Engine session propagation cmd/crossplane/render/engine.go, cmd/crossplane/render/engine_docker.go, cmd/crossplane/render/engine_local.go, cmd/crossplane/render/render.go, cmd/crossplane/render/session_test.go	Engine flags pass the session ID to both engine types. Engine setup adds it to Functions that do not already have a session annotation.
Docker resource labels cmd/crossplane/render/network.go, cmd/crossplane/render/engine_docker.go, cmd/crossplane/render/network_test.go, cmd/crossplane/render/engine_docker_test.go	Render networks and Function containers use labels derived from the session ID. Function container labels retain the cleanup-policy label.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant EngineFlags
  participant NewEngineFromFlags
  participant dockerRenderEngine
  participant Function
  participant GetRuntimeDocker
  participant Docker
  EngineFlags->>NewEngineFromFlags: pass SessionID
  NewEngineFromFlags->>dockerRenderEngine: construct with session
  dockerRenderEngine->>Function: inject session annotation during Setup
  Function->>GetRuntimeDocker: provide runtime Docker annotation
  GetRuntimeDocker->>Docker: provide session for container labels

Loading

Merge Risk: ⚪ Minimal · up to c61fe

This change adds a session label to Docker resources created by render. It is optional and falls back to a stable per-process ID, so no merge-blocking risk is evident.

Pre-merge checks: 6

Check name	Status	Explanation
Title check		The title is 54 characters, stays under the 72-character limit, and clearly describes adding session IDs to Docker resources during rendering.
Description check		The description directly explains the session label, caller-supplied session IDs, annotation behavior, fallback behavior, scope, and test coverage.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Breaking Changes		No breaking change condition is introduced. The PR changes only cmd/**; it removes no public field or flag. EngineFlags.SessionID and RuntimeDocker.Session are optional string fields, and SessionID ha…
Feature Gate Requirement		The change is not an experimental command or API feature. The authoritative diff modifies only cmd/crossplane/render; it does not touch apis/**. The render command is registered as GA, and the new…

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}