Fix 1831#1865
Merged
Merged
Conversation
The project moved to a justfile + uv build system; these legacy files were no longer referenced by any workflow, the justfile, or pyproject.toml. Verified unreferenced before removal. Removed: - Makefile.orig, Dockerfile.wheels, test-docker-builds.sh, versions.sh, deploy.sh (legacy build/deploy scripts) - mypy.ini (the typing recipe passes --config-file pyproject-static-typing.toml explicitly, so mypy.ini was never read) - .prettierrc.json (prettier is not invoked by any recipe/workflow) - docs/DOCKER_BUILDS.md, docker/README.md (documented deleted files / non-existent workflows) - pyinstaller/ hooks and the unused "pyinstaller" dev dependency (PyInstaller is no longer explicitly supported) Behavior-preserving adjustments (not pure deletions): - .coveragerc was NOT redundant: it carried `omit = */test/*.py` and there was no [tool.coverage] in pyproject.toml, so dropping it would have started counting in-package test modules in coverage. The setting was migrated to [tool.coverage.run] in pyproject.toml (coverage.py auto-discovers it) and .coveragerc removed. - Dropped the now-stale "DOCKER_BUILDS.md" entry from the Sphinx exclude_patterns in docs/conf.py. Notes: - uv.lock is gitignored (.gitignore:66) and untracked, so the "regenerate uv.lock" action item produces no committed change; it was refreshed locally and cleanly drops pyinstaller and its transitive deps (altgraph, macholib, pefile, pyinstaller-hooks-contrib, setuptools). - The .coveragerc -> pyproject migration is a small config change beyond pure file removal; flagging for human review per AI_POLICY.md. Fixes crossbario#1831. Note: This work was completed with AI assistance (Claude Code).
…crossbario#1831) Removing the pyinstaller dev dependency also dropped setuptools, which was only present transitively (uv: "Removed setuptools v82.0.1"). On Python >= 3.12 the stdlib distutils is gone, so cffi's ffi.compile() requires setuptools to be installed. `just install-tools` does an editable install of .[dev] and then runs `build-nvx` in the venv, so the NVX CFFI build broke on cpy312/cpy314: Building _nvx_utf8validator... Exception: This CFFI feature requires setuptools on Python >= 3.12. error: recipe `build-nvx` failed with exit code 1 The wheel build path is unaffected (it uses `python -m build`, whose isolated build env already gets setuptools from [build-system].requires). Fix: add setuptools>=70.0.0 explicitly to the dev extra, with a comment so it is not mistaken for unused. Reproduced the failure on a cpy314 venv (setuptools absent) and confirmed `just build-nvx cpy314` succeeds once setuptools is installed. Note: This work was completed with AI assistance (Claude Code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1831