Draft
Conversation
crodas
force-pushed
the
feature/sorted-set
branch
9 times, most recently
from
c167419 to
73be753
Compare
crodas
force-pushed
the
feature/sorted-set
branch
from
73be753 to
c2aa09b
Compare
crodas
force-pushed
the
feature/sorted-set
branch
from
c2aa09b to
d9c06f8
Compare
crodas
force-pushed
the
feature/sorted-set
branch
from
d9c06f8 to
740c9be
Compare
crodas
force-pushed
the
feature/sorted-set
branch
from
740c9be to
5e87f8e
Compare
crodas
force-pushed
the
feature/sorted-set
branch
3 times, most recently
from
a71964b to
ed41cbc
Compare
crodas
force-pushed
the
feature/sorted-set
branch
3 times, most recently
from
c02ce64 to
10b0a76
Compare
starsoccer
reviewed
Jan 25, 2024
| if args.len() % 2 != 0 { | ||
| return Err(Error::Syntax); | ||
| } | ||
| if args.len() != 2 && option.incr { |
Collaborator
There was a problem hiding this comment.
Personal opinion but why not do a match?
match v {
_ if v.is_empty() => return 1,
_ if v.len() % 2 != 0 => return 2,
_ if v.len() != 2 && option.incr => 3,
_ => return 4,
};
Owner
Author
There was a problem hiding this comment.
That's rather interesting, I like it 😄
The sorted set is a Set but sorted by a provided score associated to the value. Internally a B-Tree (to sort by score) and a HashMap are used (Value, Score).
crodas
force-pushed
the
feature/sorted-set
branch
from
10b0a76 to
23726a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sorted set is a Set but sorted by a provided score associated to the
value.
Internally a B-Tree (to sort by score) and a HashMap are used (Value,
Score).
Commands: