feat: supported eval investigation and ran attacks in isolation#115
Draft
sdhossain wants to merge 2 commits into
Draft
feat: supported eval investigation and ran attacks in isolation#115sdhossain wants to merge 2 commits into
sdhossain wants to merge 2 commits into
Conversation
tomtseng
reviewed
Apr 11, 2026
|
|
||
| if EvalName.MT_BENCH in self.attack_config.evals: | ||
| results = pl.concat([results, self.evaluate_mt_bench()]) | ||
|
|
Collaborator
There was a problem hiding this comment.
can we throw an error if results is empty?
Otherwise if we add an eval and forget to add it here to evaluate(), it silently fails and we just don't get the evaluation results. It'd be nice for things to fail earlier.
Or another idea is to make use of the evaluation registry here so that we don't have to manually add each eval here in evaluate()
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summarize the changes in this PR and describe the context or motivation for
them.
Add a title, prepending the tag [attack], [defense], [evaluation], or [infra] if
appropriate.
Testing
Describe how you tested the changes in this PR. E.g., added tests, or ran
command
fooand checked the results looked good.