Conversation
git ls-files alone returned empty for unstaged arms, so the #374 guard could go green until the moment of git add. Union with a filesystem glob so untracked results and tmp_path fixtures stay visible. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_tracked()now unionsgit ls-fileswith a filesystem glob, so unstaged results files underexperiments/*/results/are still screened (#374 guard: _tracked() is blind to untracked results files and its own tmp_path self-tests fail on main #422).Test plan
pytest tests/test_degeneracy_guard.py(43 passed)experiments/*/results/is flagged byconstant_columns/unexplainedbeforegit addCloses #422
Made with Cursor