Skip to content

feat: enable reportAny in typechecker#111

Open
snus-kin wants to merge 2 commits intomainfrom
feature/report-any-enabled
Open

feat: enable reportAny in typechecker#111
snus-kin wants to merge 2 commits intomainfrom
feature/report-any-enabled

Conversation

@snus-kin
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables stricter type checking by removing reportAny = false from the pyproject.toml configuration. This change enforces that all Any types must be explicitly addressed, improving type safety across the codebase.

Changes:

  • Enabled reportAny typechecker setting in pyproject.toml to enforce stricter type checking
  • Added cast() annotations throughout test files to handle mock objects and dynamic types
  • Added explicit type casting in source code for JSON parsing, numpy arrays, and OAuth responses

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml Removed reportAny = false to enable stricter type checking
tests/test_classify_single.py Added cast annotations for mock object access and call arguments
tests/functional/e2e/testcases/parser.py Added casts for JSON parsing and list element access
tests/functional/e2e/test_classify_single.py Replaced lambda with named function for pytest parametrize ids
tests/functional/conftest.py Added cast for pytest request.param fixture
tests/client/test_timeout_behavior.py Added cast annotations for mock client instances
tests/client/test_deployment_selector.py Added spec parameter to mocks and cast annotations
tests/client/test_channel.py Extensive cast additions for mock objects and OAuth response handling
tests/client/test_athena_client.py Added spec parameter and cast annotations for mock objects
src/resolver_athena_client/client/transformers/core.py Added cast for numpy array shape tuple
src/resolver_athena_client/client/channel.py Added casts for OAuth JSON response parsing
src/resolver_athena_client/client/athena_client.py Refactored from getattr/callable to hasattr pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@snus-kin
Copy link
Member Author

Fixes #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants