Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables stricter type checking by removing reportAny = false from the pyproject.toml configuration. This change enforces that all Any types must be explicitly addressed, improving type safety across the codebase.
Changes:
- Enabled
reportAnytypechecker setting in pyproject.toml to enforce stricter type checking - Added
cast()annotations throughout test files to handle mock objects and dynamic types - Added explicit type casting in source code for JSON parsing, numpy arrays, and OAuth responses
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removed reportAny = false to enable stricter type checking |
| tests/test_classify_single.py | Added cast annotations for mock object access and call arguments |
| tests/functional/e2e/testcases/parser.py | Added casts for JSON parsing and list element access |
| tests/functional/e2e/test_classify_single.py | Replaced lambda with named function for pytest parametrize ids |
| tests/functional/conftest.py | Added cast for pytest request.param fixture |
| tests/client/test_timeout_behavior.py | Added cast annotations for mock client instances |
| tests/client/test_deployment_selector.py | Added spec parameter to mocks and cast annotations |
| tests/client/test_channel.py | Extensive cast additions for mock objects and OAuth response handling |
| tests/client/test_athena_client.py | Added spec parameter and cast annotations for mock objects |
| src/resolver_athena_client/client/transformers/core.py | Added cast for numpy array shape tuple |
| src/resolver_athena_client/client/channel.py | Added casts for OAuth JSON response parsing |
| src/resolver_athena_client/client/athena_client.py | Refactored from getattr/callable to hasattr pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f42e88a to
eac65cb
Compare
Member
Author
|
Fixes #110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.