🛡️ Sentinel: Fix critical hardcoded admin email vulnerability - #388
🛡️ Sentinel: Fix critical hardcoded admin email vulnerability#388criptogus wants to merge 1 commit into
Conversation
…role checks - Removed hardcoded 'gustavo.caetano@gmail.com' from requireAdmin middleware. - Implemented robust RBAC checks using `user_roles` table. - Implemented legacy check for `is_admin` column in `users` table. - Preserved `ADMIN_EMAILS` environment variable fallback. - Added comprehensive unit tests in `backend/src/tests/auth-middleware.test.ts`. This fixes a critical privilege escalation vulnerability where a specific email address was granted admin access without database validation. Co-authored-by: criptogus <128640021+criptogus@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
🛡️ Sentinel: [CRITICAL] Fix hardcoded admin email vulnerability
🚨 Severity: CRITICAL
💡 Vulnerability: Hardcoded admin email allows privilege escalation.
🎯 Impact: Anyone registering with 'gustavo.caetano@gmail.com' gains full admin access automatically.
🔧 Fix: Removed hardcoded email. Implemented DB role/flag checks + ENV var support.
✅ Verification:
backend/src/tests/auth-middleware.test.tsconfirms denial of access for the specific email and grant of access for valid DB/Env admins.PR created automatically by Jules for task 2587618163097515001 started by @criptogus